Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent access to uninitialized typed properties #1005

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Prevent access to uninitialized typed properties #1005

merged 1 commit into from
Jan 22, 2021

Conversation

wfeller
Copy link
Contributor

@wfeller wfeller commented Jan 22, 2021

Fixes #1002

@driesvints
Copy link
Member

Again: this isn't a Telescope issue. This is PHP telling you you need to initialize your object properties.

@taylorotwell taylorotwell merged commit d2dbb67 into laravel:4.x Jan 22, 2021
@taylorotwell
Copy link
Member

I do indeed think this is a Telescope issue and we have handled this issue in other places before.

@taylorotwell
Copy link
Member

Telescope need not require you to initialize every property on a job just to use Telescope.

@wfeller wfeller deleted the patch-1 branch January 22, 2021 16:55
This was referenced Mar 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error parsing Job class with uninitialized typed properties
3 participants
@wfeller @driesvints @taylorotwell